-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Tagged logging #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my comments on Prefix styling
src/index.ts
Outdated
* } | ||
* | ||
* logger.log('begin'); // "begin" | ||
* fooFunction(); // "[foo]: hello" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we eliminate the colons?
logger.pushPrefix('bar'); | ||
logger.log('(and saturn!)'); // "[foo][bar]: (and saturn)!" | ||
logger.popPrefix(); | ||
logger.popPrefix(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the array is empty and there are no more Prefixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that it will not be harmful, and consistent with what developers expect from [].pop();
You work fast! Thank you for the PR |
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This feature allows prefixes to be pushed onto (and popped off of) a stack, accomplishing something similar to how Rails ActiveSupport/TaggedLogging works