Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Tagged logging #10

Merged
merged 7 commits into from
Aug 2, 2018
Merged

Conversation

mike-north
Copy link
Contributor

@mike-north mike-north commented Aug 2, 2018

PLEASE MERGE #6 BEFORE THIS

This feature allows prefixes to be pushed onto (and popped off of) a stack, accomplishing something similar to how Rails ActiveSupport/TaggedLogging works

const logger = new Logger();

function fooFunction() {
  logger.pushPrefix('foo');
  ...
  logger.log('hello');
  logger.log('world');
  ...
   logger.popPrefix();
}

logger.log('begin');   // "begin"
fooFunction();         // "[foo]: hello"
                       // "[foo]: world"
logger.log('end');     // "end"

Copy link
Owner

@lisaychuang lisaychuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my comments on Prefix styling

src/index.ts Outdated
* }
*
* logger.log('begin'); // "begin"
* fooFunction(); // "[foo]: hello"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we eliminate the colons?

logger.pushPrefix('bar');
logger.log('(and saturn!)'); // "[foo][bar]: (and saturn)!"
logger.popPrefix();
logger.popPrefix();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the array is empty and there are no more Prefixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that it will not be harmful, and consistent with what developers expect from [].pop();

@lisaychuang lisaychuang merged commit 6179400 into lisaychuang:master Aug 2, 2018
@lisaychuang
Copy link
Owner

You work fast! Thank you for the PR :shipit:

@lisaychuang
Copy link
Owner

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants