Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests are not signalled by GitHub #126

Closed
ziotom78 opened this issue Sep 9, 2021 · 0 comments · Fixed by #127
Closed

Failing tests are not signalled by GitHub #126

ziotom78 opened this issue Sep 9, 2021 · 0 comments · Fixed by #127

Comments

@ziotom78
Copy link
Member

ziotom78 commented Sep 9, 2021

Old test runs like this show that failing tests are not correctly reported as such in GitHub Actions, which mistakenly marks them with «success»:

…
test/test_destriper.py::test_destriper FAILED                            [  1%]
test/test_detectors.py::test_detector_from_dict PASSED                   [  3%]
test/test_detectors.py::test_detector_from_toml PASSED                   [  5%]
test/test_detectors.py::test_detector_from_imo PASSED                    [  7%]
…

It seems that the problem is a lack of checks in tests/run_tests.sh (which is used by the test workflow).

ziotom78 added a commit that referenced this issue Sep 9, 2021
This is done to ensure that the extended tests (PR #126) are in place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant