Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error in hwp_sys #148

Closed
sgiardie opened this issue Dec 22, 2021 · 1 comment
Closed

Small error in hwp_sys #148

sgiardie opened this issue Dec 22, 2021 · 1 comment

Comments

@sgiardie
Copy link
Contributor

At this line of the hwp_sys module the solver parameters are being read from file, so there should be the parameters self.h1s, self.h2s..., indicated by the final s, instead of the parameters self.h1, self.h2... without the s.
sgiardie added a commit that referenced this issue Dec 22, 2021
@sgiardie
Switched non-solver parameters with solver parameters at line 275 of …
41a6538 
…hwp_sys (issue #148)
@sgiardie
Copy link
Contributor Author

Also, inconsistency in the piece that handles the reading from parameter file when referring to self.sim.parameter_file

sgiardie referenced this issue Dec 30, 2021
@sgiardie
Fixed error for reading from parameter file
77d4e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgiardie