-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module for scanning a map and filling TOD #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! It looks good to me, we can merge it immediately.
Ooops, I see that the new test in the documentation (file
Probably the best way to fix this is to change the format of the output numbers from %.5e to %.5f, so that the first number is rounded to zero. |
Regarding the point about Should we decide that it is worth to save some memory, I wrote an implementation of |
Thanks, @ziotom78. I'm merging it. Let's also open an issue about g2e conversion. |
This PR provides a module able to fill obs.tod given pointing information and input map provided by mbs. It also makes obs compatible with
mapping.py
optionally fillingobs.psi
andobs.pixind
.For now, no ecliptic-to-galactic coordinate rotation is implemented internally. So
maps
should be rotated to ecliptic before being fed to the functionscan_map_in_observations
. Probably having an option in mbs for dealing with that is worthed, I'll open an issue for this.The memory handling can be improved, in particular, if psi and pixind are not filled.
Some points are still open:
scan_map_for_one_detector
to save some memory?