Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory optimization #223

Merged
merged 8 commits into from
Feb 24, 2023
Merged

Memory optimization #223

merged 8 commits into from
Feb 24, 2023

Conversation

paganol
Copy link
Member

@paganol paganol commented Feb 18, 2023

This PR introduces few memory optimizations in the code, in particular:

  • noise.py now uses fewer internal variables
  • coordinates.py now uses numba in rotate_coordinates_e2g

paganol and others added 4 commits February 18, 2023 19:06
@paganol
test fixed
66469da
@paganol
changelog updated
3cf1894
@paganol
Merge remote-tracking branch 'origin/master' into optimize_noise
596f542
@ziotom78
Speed up coordinate conversion
6c87cbf 
This change removes the need to allocate many 2-element and 3-element NumPy arrays,
providing a ×3.5 speedup for `rotate_coordinates_e2g` and
`rotate_coordinates_and_polangle_e2g`.
@paganol paganol merged commit 0afbecd into master Feb 24, 2023
@paganol paganol deleted the optimize_noise branch February 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziotom78 ziotom78 ziotom78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paganol @ziotom78