Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes, some documentation, and interface with make_bin_map #244

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Small fixes, some documentation, and interface with make_bin_map #244

merged 8 commits into from
Jun 7, 2023

Conversation

paganol
Copy link
Member

@paganol paganol commented Jun 1, 2023

This small PR:

  1. adds some documentation for the interpolator in scan_map
  2. fixes some syntax in scan_map
  3. adds an interface tomake_bin_map in simulation

@paganol paganol requested a review from ziotom78 June 1, 2023 15:18
ziotom78
ziotom78 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@ziotom78 ziotom78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

@paganol paganol merged commit 8e855d4 into master Jun 7, 2023
@paganol paganol deleted the tod_linear_interp branch June 7, 2023 10:36
@paganol paganol restored the tod_linear_interp branch June 7, 2023 11:38
@paganol paganol deleted the tod_linear_interp branch June 7, 2023 11:58
@paganol paganol mentioned this pull request Jun 7, 2023
Merged
@marcobortolami marcobortolami mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziotom78 ziotom78 ziotom78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paganol @ziotom78