Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on ducc0 to 0.8.0 #92

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Update dependency on ducc0 to 0.8.0 #92

merged 4 commits into from
Jan 20, 2021

Conversation

ziotom78
Copy link
Member

This PR updates ducc0 to version 0.8.0, which enables the use of the DUCC0_OPTIMIZATION variable. This should permit to overcome the problems described in issue #91.

@ziotom78
Copy link
Member Author

The tests ran by .github/workflows/tests.yml now take 1m30s instead of 2m40s to run: impressive!

@ziotom78
Copy link
Member Author

Ok, the documentation on Readthedocs has been built successfully (build #12798035). It completed successfully in 310 seconds: do you think this might fix #90?

@mreineck
Copy link
Collaborator

The tests ran by .github/workflows/tests.yml now take 1m30s instead of 2m40s to run: impressive!

As long as the test cases themselves are very small, this is expected, since the compile time dominates. For a large test suite with demanding tests (e.g. the one coming with ducc0), the testing time will become much longer when optimization is switched off.

It completed successfully in 310 seconds: do you think this might fix #90?

If it is a matter of memory consumed by the compiler, I'm pretty sure it will.

@ziotom78 ziotom78 merged commit 37d6cb9 into master Jan 20, 2021
@ziotom78 ziotom78 deleted the lightducc branch January 20, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants