Skip to content

Commit

Permalink
platforms/marblemini: review/cleanup.
Browse files Browse the repository at this point in the history 
- add copyrights.
- add link to documentation.
- reindent code.
- rename some IOs (for consistency with the others platforms).
- add pullup on clk20_vcxo_en.
- set clk20_vcxo as default clock.
- remove ununnecessary eth constraints. (we are using IO primitives).
- move PMODS to connectors (for consistency with others platforms).
  • Loading branch information
@enjoy-digital
enjoy-digital committed May 9, 2020
1 parent 4ffdcb5 commit 4faa91c
Showing 1 changed file with 208 additions and 199 deletions.
Loading

3 comments on commit 4faa91c

@jersey99
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enjoy-digital looks good on first pass. I am not sure I understand the rationale behind moving PMOD to a connector, don't we still need to instantiate them as pins somewhere with 3.3V? I couldn't find an example where I could use those pins as an array for example.

@jersey99
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

+_pmod0_pins = ["PMOD0:{}".format(i) for i in range(8)]
+_pmod1_pins = ["PMOD1:{}".format(i) for i in range(8)]
+break_off_pmod = [
+    ("pmod0", 0, Pins(*_pmod0_pins), IOStandard("LVCMOS33")),
+    ("pmod1", 0, Pins(*_pmod1_pins), IOStandard("LVCMOS33")),
+]
+

Adding that seemed to fix it. I found it in one of the migen platforms.

@enjoy-digital
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jersey99: 587caf7 adds your break_off_pmod pins.

Please sign in to comment.