Version 2 release: remove logrus and outdated modules #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These depended on an outdated library, and were meant mostly as aids to that library. Since the libraries are newer, they have different and ideally better ways of doing things, so don't bother trying to do a direct upgrade.
Required replacing logrus' testing tools with a new `logctx.Hook` type. Also remove sqlw since alternatives like pgx have become so popular and use different logging patterns, which now that there is slog as a common library, won't require so many workarounds like sqlw.
Go has generics now, so such utilities are not generally useful. Libraries should have generic utilities instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to version 2. Upgrading should be relatively simple but will require type changes, especially with logging.
Replace logrus with slog. Go 1.21 added the
log/slogpackage to unify structured logging.Upgrade
echoto v4.Remove some libraries (
sqlw,jwtee) which were useful in years past, but patterns have changed and there are alternative ways to do things now.