Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Git Username env variable #4315 #4915

Merged

Conversation

thiha-min-thant
Copy link
Contributor

@thiha-min-thant thiha-min-thant commented Oct 5, 2024

Proposed changes

  • Added support for setting the Git username as an environment variable (GIT_USERNAME) to ensure compatibility with Bitbucket repositories.
  • This change addresses an issue where Bitbucket requires the username explicitly, and the default system username did not work correctly for authentication.
  • Fixed Unable to import a litmushub from bitbucket(private repository) #4315

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Copy link
Contributor

@amityt amityt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @thiha-min-thant 🙌🏼

Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Saranya-jena Saranya-jena merged commit e1f0d64 into litmuschaos:master Oct 9, 2024
19 checks passed
@thiha-min-thant thiha-min-thant deleted the add-git-username-env-variable branch October 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import a litmushub from bitbucket(private repository)
4 participants