Use page_length to define how many rows to show

livebook-dev · Dec 13, 2022 · ead20a7 · ead20a7
1 parent cf87d9d
commit ead20a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/assets/data_table/main.js b/assets/data_table/main.js
@@ -123,11 +123,7 @@ function App({ ctx, data }) {
   const height = totalRows >= 10 && infiniteScroll ? 440 + headerHeight : null;
   const rowMarkerStartIndex = (content.page - 1) * content.limit + 1;
   const minColumnWidth = hasSummaries ? 150 : 50;
-
-  const rows =
-    content.page === content.max_page && !infiniteScroll
-      ? totalRows % content.limit
-      : content.limit;
+  const rows = content.page_length;
 
   const drawHeader = useCallback((args) => {
     const {

diff --git a/lib/kino/table.ex b/lib/kino/table.ex
@@ -160,6 +160,7 @@ defmodule Kino.Table do
       rows: rows,
       columns: columns,
       page: ctx.assigns.page,
+      page_length: length(rows),
       max_page: total_rows && ceil(total_rows / ctx.assigns.limit),
       total_rows: total_rows,
       order: ctx.assigns.order,