Data table improvements and fixes #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assets/data_table/main.js
Outdated
| const onItemHovered = useCallback((args) => { | ||
| const [col, row] = args.location; | ||
| row === -1 && col === -1 && args.kind === "header" | ||
| ? setHoverRows([...Array(rows).keys()]) |
There was a problem hiding this comment.
You can use this
function times(n, fn) {
return Array.from({ length: n }, (_, index) => fn(index));
}
assets/data_table/main.js
Outdated
| ? setHoverRows([...Array(rows).keys()]) | ||
| : col === -1 && args.kind === "cell" | ||
| ? setHoverRows([row]) | ||
| : setHoverRows(null); |
There was a problem hiding this comment.
Please make this an if-ifelse-else :)
josevalim
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowWrappingis nowfalse, as we don't have dynamic heights, the problems don't outweigh the benefitsmaxColumnAutoWidthwhich fixes the Textarea content is too long, is it appropriate to truncate? #217getCellsForSelectionmisscalculates the offset depending on how the rows are selected. I've temporarily fixed that on our side. Now regardless of how the selection is made, the cells are correctly copied.rowMarkers. They are now clickable numbers and have a hover effect. IMO this makes the table look more minimalist and integrated with the whole LivebookCleanShot.2022-12-07.at.22.40.11.mp4