Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataTable showing the last page #225

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fix DataTable showing the last page #225

merged 3 commits into from
Dec 14, 2022

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Dec 12, 2022

Before:

DataTable.error.mp4

After:

DataTable.fix.mp4

@aleDsz aleDsz self-assigned this Dec 12, 2022
@aleDsz aleDsz force-pushed the ale-fix-datatable branch 2 times, most recently from 60e1f59 to 563d524 Compare December 12, 2022 23:05
cristineguadelupe
cristineguadelupe approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@cristineguadelupe cristineguadelupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aleDsz! Fine by me! ❤️

assets/data_table/main.js Show resolved Hide resolved
@aleDsz aleDsz changed the title Fix loading the last page Fix DataTable showing the last page Dec 13, 2022
@aleDsz aleDsz merged commit 1df2d4e into livebook-dev:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@cristineguadelupe cristineguadelupe cristineguadelupe approved these changes

@jonatanklosko jonatanklosko Awaiting requested review from jonatanklosko

Assignees

@aleDsz aleDsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleDsz @josevalim @cristineguadelupe