Add automatic image detection #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detects the mime type of a raw image and renders it. Currently implemented for jpeg, png, svg and gif
|
@jannikbecher fantastic, thanks for the PR! |
|
@jonatanklosko thanks for this great framework! It was a pure joy try to figure out what needs to be changed :) |
Co-authored-by: Jonatan Kłosko <[email protected]>
Co-authored-by: Jonatan Kłosko <[email protected]>
|
sorry for the commit mess.. |
|
No worries, take your time. We will squash it all into a single commit when merged anyway, so it's fine :) |
|
Should be good now, thanks for the patience :) |
jonatanklosko
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to this project, and I'm excited to make my first pull request. Please let me know if there's anything I can improve!
Closes #43.
Detects image type by its magic number and renders the image as a tabbed output.
