Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for lazy data frames #283

Merged
merged 1 commit into from
May 6, 2023
Merged

Support for lazy data frames #283

merged 1 commit into from
May 6, 2023

Conversation

cristineguadelupe
Copy link
Contributor

No description provided.

josevalim
josevalim approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What do we show as total runs in this case? A question mark? Or we just show nothing?

@cristineguadelupe
Copy link
Contributor Author

LGTM! What do we show as total runs in this case? A question mark? Or we just show nothing?

A question mark and I’m disabling the next button when we reach a page without rows.

@cristineguadelupe cristineguadelupe merged commit 68dd697 into livebook-dev:main May 6, 2023
@cristineguadelupe cristineguadelupe deleted the cg-lazy-df branch May 6, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristineguadelupe @josevalim