Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chunked text and markdown outputs #318

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

jonatanklosko
Copy link
Member

lib/kino/markdown.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am not sure about the name, :streaming, :squash, :chunk, :merge are all good to me. Your call.

Co-authored-by: José Valim <[email protected]>
@jonatanklosko
Copy link
Member Author

I am not sure about the name, :streaming, :squash, :chunk, :merge are all good to me. Your call.

Initially my idea was to use :squash and always merge with the previous text regardless its mode. But then I though that if someone renders standalone text with Kino.Text.new("yo"), we shouldn't squash into that text for whatever reason. When rendering we know if the first text should be mergeable or not. Either of :chunk, :merge or :fuse would work for me, but I like :chunk a bit more because it speaks to the type of text rather than action :)

@jonatanklosko jonatanklosko merged commit 703889a into main Aug 22, 2023
1 check passed
@jonatanklosko jonatanklosko deleted the jk-text-chunks branch August 22, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants