Remote cell

[cristineguadelupe]

Hey @jonatanklosko! @josevalim told me to ask you if there's a better way to give feedback on invalid codes.

[jonatanklosko]

We can define scan_eval_result/2 and react to evaluation error any way we want. @josevalim is it for arbitrary errors, or do you have something specific in mind?

[josevalim]

@jonatanklosko it is about the case where you have invalid Elixir code in the editor. Then Code.string_to_quoted will fail. I suggest to emit something like, so once evaluated it gives you the proper error, as you can see in this PR:

Code.string_to_quoted!("invalid code here")

Any other suggestions? Is there a way to attach code comments to the generated code?

[cristineguadelupe]

We can define scan_eval_result/2 and react to evaluation error any way we want. @josevalim is it for arbitrary errors, or do you have something specific in mind?

Wait! I think I was a bit vague. 🙈
The problem is to provide feedback before evaluating. While typing the code and without crashing the SmartCell

[jonatanklosko]

@josevalim perhaps it would be less confusing if we generated code with explicit raise "..."?

Is there a way to attach code comments to the generated code?

def to_source(attrs) returns string, so it can be anything we want.

[josevalim]

@jonatanklosko the problem is raising the explicit syntax error that we get. What do you think about generating this:

# Invalid code for RPC, reproducing the error below
Code.string_to_quoted!(...)

?

[jonatanklosko]

Sounds good!

[josevalim]

I think we actually don't need this call. :erpc connects automatically! Please verify:

Suggested change

Node.connect(node)

[josevalim]

Btw, we should allow the cookie to be a secret, but we can move that to a separate issue. :)

[jonatanklosko]

Suggested change

	to_quoted(attrs, code)
	to_source(attrs, code)

[josevalim]

Nitpick: should we interpolate the cookie directly here?

Suggested change

	Node.set_cookie(node, cookie)
	Node.set_cookie(node, unquote(String.to_atom(cookie)))

[cristineguadelupe]

I think that if we do it for one, we should do it for both

[josevalim]

I don't think so because node we repeat (we use it more than once). We don't do so for cookie!

[jonatanklosko]

Suggested change

	/>
	</form>
	/>
	</div>
	</form>