Custom Label Logic

[mariari]

This topic addresses #408

I added an extra argument to seq_trace and render_seq_trace, that accepts an extra argument to augment the labeling logic.

I have not tested the code yet, nor did I see any tests in the repo.

I hope it works.

I am now going to test this in a project I'm working on, and might add an extra commit that augments the example, showing off what the custom label can do.

I've also exposed label_from_value as I think it may add some value to people's custom's logic's

  @spec foo(term()) :: label_response()
  defp foo(message) do
    case message do
      {:"$gen_call", _ref, {:special, _, msg}} -> "CALL: #{label_from_value(msg)}"
      {:"$gen_cast", _ref, {:special, _, msg}} -> "CAST: #{label_from_value(msg)}"
      _ -> :continue
    end
  end

is one such logic I used in mocking up what I wanted to do. I will get a better example as I make more examples.

[mariari]

The code seems to work!

[josevalim]

Can we call it :message_label? We usually don't append the type to the option names.

I also don't think we should expose label_from_value. If you pass a custom function, you usually know better which values you are going to handle, no?

[mariari]

Can we call it :message_label? We usually don't append the type to the option names.

Sure, let me change that now.

I also don't think we should expose label_from_value. If you pass a custom function, you usually know better which values you are going to handle, no?

Most likely, I just wanted to preserve the initial message, as the code I'll be running it on just wraps the normal GenServer.call and GenServer.cast with some extra information to the given GenServer, meaning the default behavior is close to what I wanted but not quite.

[mariari]

Both complaints should be addressed now on the latest push

[mariari]

I have also provided an example in the documentation now on how to run the new message_label option

[josevalim]

💚 💙 💜 💛 ❤️