Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sample data for empty data #427

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix: sample data for empty data #427

merged 1 commit into from
May 16, 2024

Conversation

cristineguadelupe
Copy link
Contributor

jonatanklosko
jonatanklosko approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍵

@cristineguadelupe cristineguadelupe merged commit 1b18ca9 into livebook-dev:main May 16, 2024
1 check passed
@cristineguadelupe cristineguadelupe deleted the cg-fix-table-empty-data branch May 16, 2024 06:32
@josevalim
Copy link
Contributor

Is it possible to have a test?

@cristineguadelupe
Copy link
Contributor Author

Is it possible to have a test?

Done! Gonna add one for KinoExplorer too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristineguadelupe @josevalim @jonatanklosko