Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbg pipeline when result renders as Kino.JS.Live #453

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jonatanklosko
Copy link
Member

@jonatanklosko jonatanklosko commented Jul 3, 2024

Currently a pipeline with Explorer operations and |> dbg() hangs and times out. The pipeline c:Kino.JS.Live.init/1 calls Kino.Frame.render/2, which may result in Kino.start_child/1 underneath. In the past Kino.Frame.render/2 used GenServer.cast, so the init callback would not block, finish and unlock the other Kino.start_child/1. However, we changed Kino.Frame.render/2 to use GenServer.call (aae7a1b), so now init blocks, but the nested Kino.start_child/1 hangs, until init times out.

To fix it, I moved Kino.Frame.render/2 from init to a subsequent handle_info.

@jonatanklosko jonatanklosko merged commit e34687e into main Jul 3, 2024
1 check passed
@jonatanklosko jonatanklosko deleted the jk-fix-dbg-child-render branch July 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants