Renders ETS as tuples #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given rows are always Elixir terms I wonder if it would make sense to always print them in |
|
@wojtekmach good call! Actually, I'm wondering if we should just always use monospaced font for the table, since we generally show inspected data. This way the styling would be consistent. |
|
@jonatanklosko I think monospaced functions will be bad for database data. We should definitely allow multiple representations there. It should be an option. |
|
Monospaced won't be good for Explorer either. :) |
|
@josevalim to be honest I think it looks better. Deepnote uses monospaced font for the tables too :)
|
cristineguadelupe
force-pushed
the
cg-ets-tuple
branch
from
0fd33d7
to
1fdcd18
Compare
josevalim
approved these changes
Feb 8, 2022
jonatanklosko
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we show ETS tables. Now we always have only one column named
rowsand all rows are just tuples.