Restore whether the variable is a dataframe on load #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Apr 9, 2024
| "assign_to" => nil, | ||
| "lazy" => true, |
There was a problem hiding this comment.
I'm pretty sure we don't use this anywhere.
jonatanklosko
commented
Apr 9, 2024
| @@ -967,11 +973,6 @@ defmodule KinoExplorer.DataTransformCell do | |||
|
|
|||
| defp implements?(protocol, value), do: protocol.impl_for(value) != nil | |||
|
|
|||
| defp is_data_frame?(ctx) do | |||
| df = ctx.assigns.root_fields["data_frame"] | |||
| Map.get(ctx.assigns.data_frame_variables, df) | |||
There was a problem hiding this comment.
Sidenote: the reason for the linked issue is that here, if we have no variable information, we would return nil, which fails the guard defp lazy(nodes, %{is_data_frame: false}), do: nodes, and consequently produces a read-lazy code, which may not be applicable.
josevalim
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes livebook-dev/livebook#2547.
We generate code conditionally depending on whether the variable is a dataframe. Currently we compute that on the fly based on the list of dataframe variables we know. However, when the runtime just started, this list is empty. This PR changes it such that we restore the value of
is_data_frameand only change it when the variable is available.