Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: maptiler external key as secret #59

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix: maptiler external key as secret #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96b2df
Fix: maptiler external key as secret
cristineguadelupe Sep 5, 2023
c017074
Applying suggestions
cristineguadelupe Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kino_maplibre/map_cell.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ defmodule KinoMapLibre.MapCell do
"center" => attrs["center"],
"zoom" => attrs["zoom"] || 0,
"maptiler_key" => attrs["maptiler_key"],
"use_maptiler_key_secret" => attrs["use_maptiler_key_secret"] || true,
"use_maptiler_key_secret" => Map.get(attrs, "use_maptiler_key_secret", true),
"maptiler_key_secret" => attrs["maptiler_key_secret"]
}

Expand Down
30 changes: 30 additions & 0 deletions test/kino_maplibre/map_cell_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,36 @@ defmodule KinoMapLibre.MapCellTest do
"""
end

test "maptiler external key as secret - from attrs" do
root = %{
"use_maptiler_key_secret" => true,
"maptiler_key_secret" => "MAPTILER_SECRET_KEY",
"style" => "street (commercial)"
}

attrs = Map.merge(@root, root)
{_kino, source} = start_smart_cell!(MapCell, attrs)

assert source == """
MapLibre.new(style: :street, key: System.fetch_env!("LB_MAPTILER_SECRET_KEY"))\
"""
end

test "maptiler external key as input - from attrs" do
root = %{
"use_maptiler_key_secret" => false,
"maptiler_key" => "MAPTILER_KEY",
"style" => "street (commercial)"
}

attrs = Map.merge(@root, root)
{_kino, source} = start_smart_cell!(MapCell, attrs)

assert source == """
MapLibre.new(style: :street, key: "MAPTILER_KEY")\
"""
end

describe "code generation" do
test "source for a default empty map" do
attrs = Map.merge(@root, %{"layers" => [@default_layer]})
Expand Down
Loading