Add geocode #69
Merged
Add geocode #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 12, 2024
lib/assets/maplibre/main.js
Outdated
| @@ -1,12 +1,17 @@ | |||
| import "https://cdn.jsdelivr.net/npm/[email protected]/dist/maplibre-gl.min.js"; | |||
| // TODO: point to npm when released | |||
| import "https://cdn.jsdelivr.net/gh/jimmyrocks/maplibre-gl-vector-text-protocol@main/dist/maplibre-gl-vector-text-protocol.min.js"; | |||
| import "https://unpkg.com/@maplibre/[email protected]/dist/maplibre-gl-geocoder.min.js"; | |||
There was a problem hiding this comment.
Ideally we would depend on fewer CDNs, to have fewer points of failure. I assume this is not on jsdelivr though? :(
There was a problem hiding this comment.
We can esbuild, as we've done in kino!
There was a problem hiding this comment.
I've switched to jsdelivr and will soon convert it to esbuild
cristineguadelupe
force-pushed
the
cg-add-geocode
branch
from
10cfcc6
to
a36e362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-01-11.at.19.11.48-converted.mov