Fix Teams app deployments with attachment files

livebook-dev · Oct 4, 2024 · 57ef442 · 57ef442
1 parent 50b60f0
commit 57ef442
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/livebook/apps/teams_app_spec.ex b/lib/livebook/apps/teams_app_spec.ex
@@ -58,6 +58,8 @@ defimpl Livebook.Apps.AppSpec, for: Livebook.Apps.TeamsAppSpec do
   end
 
   defp unzip(archive_binary, files_tmp_path) do
+    File.mkdir_p!(files_tmp_path)
+
     case :zip.extract(archive_binary, [:memory]) do
       {:ok, entries} ->
         Enum.reduce_while(entries, {:error, "notebook file missing in the app archive"}, fn

diff --git a/test/livebook_teams/hubs/team_client_test.exs b/test/livebook_teams/hubs/team_client_test.exs
@@ -633,12 +633,15 @@ defmodule Livebook.Hubs.TeamClientTest do
       notebook = %{
         Livebook.Notebook.new()
         | app_settings: %{Livebook.Notebook.AppSettings.new() | slug: slug},
+          file_entries: [%{type: :attachment, name: "image.jpg"}],
           name: title,
           hub_id: team.id,
           deployment_group_id: deployment_group_id
       }
 
       files_dir = Livebook.FileSystem.File.local(tmp_dir)
+      image_file = Livebook.FileSystem.File.resolve(files_dir, "image.jpg")
+      :ok = Livebook.FileSystem.File.write(image_file, "content")
 
       {:ok, %Livebook.Teams.AppDeployment{file: zip_content} = app_deployment} =
         Livebook.Teams.AppDeployment.new(notebook, files_dir)