Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow image upload when no name provided #1083

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Allow image upload when no name provided #1083

merged 1 commit into from
Apr 1, 2022

Conversation

BrooklinJazz
Copy link
Contributor

@BrooklinJazz BrooklinJazz commented Apr 1, 2022 •
edited
Loading

This is my first Livebook PR, please let me know if I can make any changes!

resolves #1080

Image uploads no longer require the name field and instead use the entry file name as the default value.

image

image

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jonatanklosko
jonatanklosko approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks :)

@jonatanklosko jonatanklosko merged commit 00c913a into livebook-dev:main Apr 1, 2022
@BrooklinJazz BrooklinJazz deleted the non-mandatory-name-field-for-image-upload branch April 18, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name field is mandatory for images when it should be optional.
3 participants
@BrooklinJazz @CLAassistant @jonatanklosko