Show the correct amount of free memory available on the system #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to use the `available_memory` stat, otherwise tries to cobble it together using cached+buffered+free as per the erlang docs on `:memsup:get_system_memory_data` and only failing that flals back to `free_memory`
|
|
josevalim
approved these changes
May 9, 2022
Co-authored-by: Jonatan Kłosko <[email protected]>
|
The CLA link is not working for me, btw. So I can't actually sign it :/ |
|
@aseigo can you please try again? And if it still fails, which error are you running into? |
|
It worked this time, @josevalim :) From the web console, it was getting errors from a github REST endpoint ... :/ But it works now! So, all's well that ends well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to use the
available_memorystat, otherwise tries to cobble it together using cached+buffered+free as per the erlang docs on:memsup:get_system_memory_dataand only failing that flals back tofree_memory.I have only been able to test it so far on Linux, but have tested all the branches of the
measure_free_memoryfunctions. Testing it on other OS's would be good.Incorrect without this patch:
Correct, after this patch:
.