-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for audio input #1610
Conversation
Uffizzi Preview |
Looks great! My only suggestions are:
|
Screen.Recording.2022-12-29.at.12.14.47.mov |
@jonatanklosko last nitpick: have the recording button come first and then the upload the one. So the recording button is on the same side as the stop recording button. Then :) |
@josevalim should we mirror it for the image input too? (Open camera/take photo on the left, upload/cancel on the right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
audio_input.mp4