Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for reevaluating apps on change and add retry for errors #2066

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

jonatanklosko
Copy link
Member

  • apps no longer reevaluate automatically; when an input changes we show an indicator on the input and a button to process the changes
  • on error we show a retry button alongside "Something went wrong", consistently with interrupt
  • new status indicator in the corner
app_reevaluation.mp4

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Uffizzi Preview deployment-30778 was deleted.

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one tiny comment in the text. I would also make the input icon a bit lighter/brighter, so it calls even less attention, but it is your call. :)

@jonatanklosko jonatanklosko merged commit de2fc2f into main Jul 13, 2023
6 checks passed
@jonatanklosko jonatanklosko deleted the jk-apps-eval branch July 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants