Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate warmup_apps.sh in favour of warmup_apps #2305

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Deprecate warmup_apps.sh in favour of warmup_apps #2305

merged 2 commits into from
Oct 25, 2023

Conversation

jonatanklosko
Copy link
Member

For consistency with /app/bin/livebook.

@josevalim
Copy link
Contributor

We need to update the generated docker files to use warmup_apps instead of warmups_apps.sh.

@josevalim
Copy link
Contributor

There is also one mention of warmup_apps.sh in the README. :)

@jonatanklosko
Copy link
Member Author

jonatanklosko commented Oct 25, 2023 •
edited
Loading

Whoops, updated!

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Uffizzi Preview deployment-39376 was deleted.

@jonatanklosko jonatanklosko merged commit f2c5d10 into main Oct 25, 2023
7 checks passed
@jonatanklosko jonatanklosko deleted the jk-warmup-apps branch October 25, 2023 10:18
jonatanklosko added a commit that referenced this pull request Oct 25, 2023
@jonatanklosko
Deprecate warmup_apps.sh in favour of warmup_apps (#2305)
08ce037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatanklosko @josevalim