Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the code editor to CodeMirror #2444

Merged
merged 2 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Livebook is a web application for writing interactive and collaborative code not

* Code notebooks with Markdown support and Code cells where Elixir code is evaluated on demand.

* Rich code editor through [Monaco](https://microsoft.github.io/monaco-editor/): with support for autocompletion, inline documentation, code formatting, etc.
* Rich code editor through [Code Mirror](https://codemirror.net/): with support for autocompletion, inline documentation, code formatting, etc.
jonatanklosko marked this conversation as resolved.
Show resolved Hide resolved

* Interactive results via [Kino](https://github.com/elixir-nx/kino): display [Vega-Lite charts](https://vega.github.io/vega-lite/), tables, maps, and more.

Expand Down
12 changes: 0 additions & 12 deletions assets/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,6 @@ const outDir = path.resolve(
);

async function main() {
await esbuild.build({
entryPoints: [
"./node_modules/monaco-editor/esm/vs/language/json/json.worker.js",
"./node_modules/monaco-editor/esm/vs/editor/editor.worker.js",
],
outdir: outDir,
bundle: true,
target: "es2017",
format: "iife",
minify: deploy,
});

const ctx = await esbuild.context({
entryPoints: ["js/app.js"],
outdir: outDir,
Expand Down
1 change: 0 additions & 1 deletion assets/css/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@
@import "./ansi.css";
@import "./js_interop.css";
@import "./tooltips.css";
@import "./editor.css";
@import "./notebook.css";
218 changes: 0 additions & 218 deletions assets/css/editor.css

This file was deleted.

2 changes: 1 addition & 1 deletion assets/css/markdown.css
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
}

.markdown pre {
@apply flex overflow-hidden;
@apply my-4 flex overflow-hidden;
}

.markdown pre > code {
Expand Down
Loading
Loading