Rename Hubs to Workspaces #2574
Conversation
|
Uffizzi Preview |
| @@ -1192,7 +1192,7 @@ defmodule LivebookWeb.SessionLive.Render do | |||
| class="inline-flex items-center cursor-pointer gap-1 mt-1 text-sm text-gray-600 hover:text-gray-800 focus:text-gray-800" | |||
| aria-label={@data_view.hub.hub_name} | |||
| > | |||
| <span>in</span> | |||
There was a problem hiding this comment.
Before
After
I changed that part because I don't think the relationship between a notebook and a workspace is that a "notebook" is "in" a "workspace".
A notebook is "in" a file system or "in" a GitHub repo, in my opinion.
I actually think a notebook "uses" a "workspace".
A workspace is basically a collection of configurations and resources:
- secrets
- file storages
- deployment groups (if it's a teams workspace)
- stamping secret key OR teams key
When we associate a notebook with a workspace, we allow that notebook to access the resources belonging to that workspace.
That's why I changed the "in" preposition here to something else.
That said, I didn't like how the aesthetics of the result ended up when I changed to "workspace" instead of "in". Specially for the default personal "My Workspace".
If you have any suggestions to improve the design or the text, I'm open to it.
There was a problem hiding this comment.
Changing the wording sounds good to me.
I actually think a notebook "uses" a "workspace".
So perhaps "using 🏠 My Workspace"?
Another option would be to skip the prefix altogether, which I think is fine. @josevalim?
There was a problem hiding this comment.
Aesthetically, I liked "using" better than "workspace".
Before
After
There was a problem hiding this comment.
But now, I'm having second thoughts. Maybe we should keep the label "Workspace". It's easier to say to someone that is having any kind of doubt to "go to your notebook, at the top, you can change the workspace it's associated to".
So, another way could be:
- the label is "Workspace"
- the default name of the personal workspace is "Personal".
So, we would have:
Home
Notebook associated with personal workspace
Notebook associated with teams workspace
That's my new preference.
Let's go this way, shall we?
There was a problem hiding this comment.
Works for me, and I like "My Hub" -> "Personal" as it's more consistent with org names.
There was a problem hiding this comment.
What about “using [v Personal] workspace”?
There was a problem hiding this comment.
@josevalim nice idea!
Here are a few options.
But before, here's some context (the workspace names in the example):
Option 1 (with "using", like you suggested)
Option 2 (with "using", but chevron after "workspace")
Option 3 (without "using")
My preference
I prefer option 2:
- it looks like
- it contains the word "using", so it clearly shows there's an association between the notebook and the workspace
Should we go with option 2?
@josevalim, what do you think?
There was a problem hiding this comment.
What if we do "using ICON Personal CHEVRON workspace"?
There was a problem hiding this comment.
What if we do "using ICON Personal CHEVRON workspace"?
I liked that. 👍
Here's what it looks like:
Done in 3ba93f1
I think now we're ready to merge. What do you think @josevalim ?
| @@ -19,7 +19,7 @@ defmodule LivebookWeb.Hub.EditLive do | |||
| hub: nil, | |||
| counter: 0, | |||
| type: nil, | |||
| page_title: "Hub - Livebook", | |||
| page_title: "Workspace - Livebook", | |||
There was a problem hiding this comment.
There is an error message here to change "Hub deleted"
|
There are entries in these files. Search for "hub " or "Hub " (with space) in these files:
|
Good catch, thank you! Done in 5c1db8e Did you use the shell command to find those? I was doing |
@hugobarauna I searched for "hub " |
I was talking to José, and I believe we should make a few nomenclature changes. This is probably the main one.
I talked to him, and he suggested only changing the text that is shown to the user instead of also changing the code.