Allow disconnecting Fly runtime during initialization #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes connecting may take quite a bit, and the user may realise that they want to change the config. Instead of waiting for the connection to finish, this allows them to hit "Disconnect".
Runtime.connectis already designed to return a pid that the session monitors. When the disconnect happens while connecting, the session is going to kill that process directly. For the Fly runtime, we have an additional watcher that eagerly deletes the machine in such case (if created).Initially I thought about extending
Runtime.disconnectto handle connecting state, but we would need to keep track of pid in each runtime struct and also have more duplication. Since the session already expects pid responsible for connecting, I think a direct kill is fine. // EDIT: I've just realised an added benefit of the current approach is that the same cleanup is triggered if something else fails during initialization (e.g. setting up the proxy).