Share code between Fly and K8s runtimes #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Sep 18, 2024
|
|
||
| @doc """ | ||
| Returns a new runtime instance. | ||
| """ | ||
| @spec new(config :: map(), req :: Req.Request.t()) :: t() | ||
| def new(config, req) do |
There was a problem hiding this comment.
@mruoss I missed that before, I think preferably we don't want to pass the whole req struct when building the runtime, and rather encapsulate the necessary logic within the runtime itself (even if we do the same elsewhere) :)
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2756.