Implements the go back and forward keyboard shortcuts

[aleDsz]

No description provided.

[github-actions]

Uffizzi Preview deployment-56452 was deleted.

[josevalim]

It looks good to me. Feel free to ship it once Jonatan approves. :)

[jonatanklosko]

We can check if the selection changed:

!update.state.selection.eq(update.startState.selection)

I would make the event more specific liveEditor.onSelectionChange and have that check there.

The only difference is that when the user goes into insert mode in existing cell, the selection doesn't change, so we can call sendCursorHistory on focus separately.

Once we do that, I don't think we need the setTimeout here (since it's only specific to the focus case?). wdyt?

[aleDsz]

I'm not sure if I understood about the focus change, because it makes the pubsub event to be dispatched twice

[jonatanklosko]

My idea is that in onFocus we do this:

if (!this.isFocused || !this.insertMode) {
  this.currentEditor().blur();
} else {
  this.sendCursorHistory();
}

This way we send the cursor history when the editor is focused and when the cursor changes location within the editor (focusing alone does not change the cursor location).

[jonatanklosko]

🚢