-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the Google Workspace ZTA #2809
Conversation
Uffizzi Preview |
<img | ||
:if={@user.email} | ||
src={"https://gravatar.com/avatar/#{hash_email(@user.email)}"} | ||
class="rounded-full" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid Gravatar (especially without user's consent) see https://meta.stackexchange.com/q/44717 :)
defp validate_access_token(req, token) do | ||
Logger.debug("[#{inspect(__MODULE__)}] requesting google api") | ||
|
||
case Req.get(req, url: @userinfo_path, params: %{access_token: token}) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we validate if the user belongs to a certain workspace? Otherwise I can get a token for my own workspace and use it to pass the validation?
No description provided.