Remove delete prompt for empty sections #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a section has no cell views or only empty cell views, avoid prompting the user to delete the section and just go ahead and delete it. Closes livebook-dev#800
|
|
This avoids creating two separate paths in the view for displaying delete buttons (triggering either a prompt, or deleting the empty section). Instead, the `delete_section` callback is always triggered, and the "display prompt" logic is kept here. Couple of things I'm unsure about so will discuss on the PR. See livebook-dev#829 (comment)
leejarvis
force-pushed
the
remove-prompt-for-deleting-empty-sections
branch
from
c261cf6
to
75409ff
Compare
Also explicitly set the section and then re-use it. I think this is a bit nicer than just matching against the empty list since it matches the following match too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a section has no cell views or only empty cell views, avoid
prompting the user to delete the section and just go ahead and delete
it.
Added a separate hook in SessionLive to avoid invoking the delete prompt
component. I'm not sure if additional protection should be added to the
delete_empty_sectioncallback to ensure the session is empty. Happy tomake further tweaks if there's a better way to handle this.
See #800