Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set page name when notebook is renamed #844

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Set page name when notebook is renamed #844

merged 5 commits into from
Jan 6, 2022

Conversation

dkuku
Copy link
Contributor

@dkuku dkuku commented Jan 5, 2022

#835 Short pr to solve this issue. On new notebook we still have Livebook in the title, I did not wanted to name the tab Untitled or renaming the default notebook
image

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jonatanklosko
jonatanklosko approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for adding the test! :shipit:

@jonatanklosko jonatanklosko merged commit 6185931 into livebook-dev:main Jan 6, 2022
@jonatanklosko jonatanklosko mentioned this pull request Jan 6, 2022
Closed
@dkuku dkuku deleted the custom_browser_tab_name branch January 6, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkuku @CLAassistant @jonatanklosko