Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current version section to settings page #851

Merged
merged 3 commits into from Jan 12, 2022
Merged

Add current version section to settings page #851

merged 3 commits into from Jan 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2022

Issue

Add dashboard button to settings #849

Changes

Add the Current Version section to the Settings page with two buttons for shutdown (stays on the current page) and patching in the dashboard.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022

CLA assistant check
All committers have signed the CLA.

@ghost ghost changed the title Add dashboard button to settings #849 Add current version section to settings page Jan 10, 2022
@jonatanklosko
Copy link
Member

jonatanklosko commented Jan 11, 2022

Hey @julngomz thanks for working on this! I think we should move the info as a subsection of "System settings", right below "File systems".

Design wise, it would be neat to use the same styling that we use for file systems, so a box like this:

Version      Elixir    
*v0.4.1*     *v1.13.0*

And the dashboard button would go in that box on the very end. You can reuse the styling from FileSystemsComponent.

As for the shutdown button, @josevalim will add it separately, so I'd ignore it for now.

@josevalim
Copy link
Contributor

Quick amendment: let's have it above file systems. It should be the first subsection. :)

@jonatanklosko
Copy link
Member

Did a couple adjustments, thanks @julngomz!

@jonatanklosko jonatanklosko merged commit bf94998 into livebook-dev:main Jan 12, 2022
<h4>
<%= case field do %>
<% :version -> %>
<%= Mix.Project.config[:version] %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A heads up: we shouldn't use Mix.Project inside lib because Mix is not available in releases. I will push a fix shortly. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants