Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor design improvements #858

Merged

Conversation

cristineguadelupe
Copy link
Contributor

Icon Buttons - from 2.56 to 4.76 contrast ratio
Screen Shot 2022-01-12 at 17 32 08
Screen Shot 2022-01-12 at 17 38 57

Labeled text - from xs to sm font-size
Screen Shot 2022-01-12 at 20 27 25
Screen Shot 2022-01-12 at 20 26 56

Runtime sidebar buttons - Safari fix
Screen Shot 2022-01-12 at 20 28 29
Screen Shot 2022-01-12 at 21 33 16

Toggleable menu - better contrast on hover
Screen Shot 2022-01-12 at 22 13 03
Screen Shot 2022-01-12 at 22 13 26

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment and feel free to merge then!

@@ -285,7 +285,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do

defp cell_status(%{cell_view: %{validity_status: :stale}} = assigns) do
~H"""
<.status_indicator circle_class="bg-yellow-200" change_indicator={true}>
<.status_indicator circle_class="bg-yellow-bright-200" change_indicator={true}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mirror the status in the bottom-right indicators and in sections panel, if you look bg-yellow-200 you should find all places :D

@cristineguadelupe cristineguadelupe merged commit 9690e2a into livebook-dev:main Jan 13, 2022
@cristineguadelupe cristineguadelupe deleted the cg-contrast-improvements branch January 13, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants