Adds a bit of contrast to the comments in the code editor #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristineguadelupe
force-pushed
the
cg-comments-contrast
branch
from
98cd25e
to
30d94d2
Compare
josevalim
reviewed
Jan 13, 2022
assets/js/cell/live_editor/theme.js
Outdated
| @@ -4,7 +4,7 @@ const colors = { | |||
| default: "#abb2bf", | |||
| lightRed: "#e06c75", | |||
| blue: "#61afef", | |||
| gray: "#5c6370", | |||
| gray: "#737A8C", | |||
There was a problem hiding this comment.
Suggested change
| gray: "#737A8C", | |
| gray: "#737a8c", |
josevalim
reviewed
Jan 13, 2022
assets/css/ansi.css
Outdated
| @@ -14,7 +14,7 @@ to be consistent with the editor. | |||
| --ansi-color-magenta: #c678dd; | |||
| --ansi-color-cyan: #56b6c2; | |||
| --ansi-color-white: white; | |||
| --ansi-color-light-black: #5c6370; | |||
| --ansi-color-light-black: #737a8c; | |||
There was a problem hiding this comment.
This font is used on white background I think. Are we sure we want to change it?
There was a problem hiding this comment.
The difference on white backgrounds is less prominent than on dark backgrounds, but the old gray is no doubt better, and I'm keeping it.
jonatanklosko
approved these changes
Jan 13, 2022
|
@cristineguadelupe i think the change you did to code comments was good, I think we should just use two different shades of gray. One for comments, another for ansi. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current color, the comments are almost unreadable. A little more contrast while keeping the same shade of gray increases readability without losing the consistency of the theme.