Add shutdown button #862
Merged
Add shutdown button #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/livebook_web/live/home_live.ex
Outdated
| path={Routes.settings_path(@socket, :page)} | ||
| active={false} /> | ||
| <SidebarHelpers.user_item current_user={@current_user} path={Routes.home_path(@socket, :user)} /> | ||
| <SidebarHelpers.shared_home_footer socket={@socket} current_user={@current_user} /> |
There was a problem hiding this comment.
Maybe default_footer, since we mirror it everywhere except the session page?
There was a problem hiding this comment.
The naming is tricky. I am calling "home" all of the explorer, settings, etc. I think default is not very descriptive. :'( Any other ideas?
There was a problem hiding this comment.
shared_home_footer -> shared_footer 🙈
I cannot think of a good word to describe all off-session pages :<
There was a problem hiding this comment.
Yeah, I will keep the naming as is, those are all home-like pages or accessible from home. Once we expand things maybe we will have better naming ideas.
The button only appears on interactive mode because we assume embedded mode is running inside a release or similar.
josevalim
force-pushed
the
jv-add-shutdown-button
branch
from
95f143f
to
9568d6f
Compare
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button only appears on interactive mode because
we assume embedded mode is running inside a release
or similar.