Set root path to $HOME #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
reviewed
Jan 19, 2022
app_builder/lib/app_builder/macos.ex
Outdated
| @@ -142,7 +142,7 @@ defmodule AppBuilder.MacOS do | |||
| #!/bin/sh | |||
| set -e | |||
| root=$(dirname $(dirname "$0")) | |||
| $root/Resources/rel/bin/#{release_name} start \ | |||
| LIVEBOOK_ROOT_PATH=$HOME $root/Resources/rel/bin/#{release_name} start \ | |||
There was a problem hiding this comment.
we shouldn't put Livebook specific stuff into app_builder/.
Instead, let's set this env var in rel/app/env.* and we should be good to go!
There was a problem hiding this comment.
@wojtekmach Yes, that makes sense.
I just updated the PR.
wojtekmach
approved these changes
Jan 19, 2022
josevalim
reviewed
Jan 19, 2022
Co-authored-by: José Valim <[email protected]>
josevalim
approved these changes
Jan 19, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default root path when starting the livebook macOS app was
/.I think it would be better, if it is started with
$HOMEas root path.The best solution would probably be a configurable root path from within the app.
@wojtekmach Is something like that possible with wxWidgets?