Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute iframe base URL based on page origin #902

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Compute iframe base URL based on page origin #902

merged 2 commits into from
Jan 20, 2022

Conversation

jonatanklosko
Copy link
Member

Closes #901.

When merged, I will wait for the Docker built and make sure it works on fly.io.

@jonatanklosko jonatanklosko merged commit a9f9c68 into main Jan 20, 2022
@jonatanklosko jonatanklosko deleted the jk-iframe-base branch January 20, 2022 10:29
@jonatanklosko
Copy link
Member Author

Works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customizable URL for livebook
2 participants
@jonatanklosko @josevalim