-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk actions for sessions #939
Bulk actions for sessions #939
Conversation
This is looking great! Some feedback:
EDIT:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work using LiveView.JS
! A couple more comments from me 🐱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I have only dropped very minor comments.
However, I think we need a test that goes through the process of:
- Starting a runtime
- Closing it off via a bulk action
- Verifying the runtime is gone
Once that is ready, this is all done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! 🐱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely beautiful! I have dropped one very tiny comment!
Co-authored-by: José Valim <[email protected]>
Closes #914
Screen.Recording.2022-01-28.at.17.20.17.mov