Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvements - home page #979

Merged
merged 9 commits into from
Feb 4, 2022
Merged

Accessibility improvements - home page #979

merged 9 commits into from
Feb 4, 2022

Conversation

cristineguadelupe
Copy link
Contributor

The main improvements are:

  • Headings and landmarks navigation
  • The addition of missing aria labels
  • Important information at the action level
  • Direct instructions at the input level

jonatanklosko
jonatanklosko reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just some capitalization nitpicks :)

lib/livebook_web/live/home_live.ex Outdated Show resolved Hide resolved
lib/livebook_web/live/home_live/session_list_component.ex Outdated Show resolved Hide resolved
lib/livebook_web/live/home_live.ex Outdated Show resolved Hide resolved
lib/livebook_web/live/home_live.ex Outdated Show resolved Hide resolved
lib/livebook_web/live/file_select_component.ex Outdated Show resolved Hide resolved
@cristineguadelupe cristineguadelupe merged commit 904a21a into livebook-dev:main Feb 4, 2022
@cristineguadelupe cristineguadelupe deleted the cg-accessibility-home branch February 4, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristineguadelupe @jonatanklosko