Move build cache and fallback to copying #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods to reduce chances of forgetting to passing a required value to a struct.
This was referenced May 15, 2022
matthewmueller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes where cached builds are placed:
$TMPDIR/bud/cache$YOUR_APP/bud/cacheto fix #27.
The
./bud/directory should generally be ignored by source control anyways. If you do choose to vendor the./bud/directory, you can always git ignore./bud/cache/. You could also runbud tool cache cleanto remove thebud/cachedirectory.We may find that this clutters up the project's
bud/directory too much, but it's better to try and unblock people, then figure out the ideal solution later.I also hopefully fixed #30 and #46 with b906630.
This PR is a bit messier than I would have liked, but I took the opportunity to do some additional testing and cleanup. The main changes are in:
So overall, I'm hoping this PR resolves #27, #30 and #46 🤞