Fix attribute defaults from active_attr #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attribute defaults were broken by the change to attribute initialization and typecasting. This pulls over the active_attr attribute defaults, and fixes them to work with the way active_remote is doing attribute initialization and typecasting.
|
|
|
Released in v2.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute defaults were broken by the change to attribute initialization
and typecasting.
This pulls over the active_attr attribute defaults, and fixes them to
work with the way active_remote is doing attribute initialization and
typecasting.
We could probably monkeypatch this in but I thought this approach
was cleaner. Let me know what you think.