Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove search callbacks #55

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Remove search callbacks #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47bee58
Remove search callbacks
brianstien Feb 22, 2017
8ab0766
Remove deprecated search method
brianstien Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions lib/active_remote/search.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ module Search
included do
include Persistence
include RPC

define_model_callbacks :search
end

module ClassMethods
Expand Down Expand Up @@ -94,7 +92,6 @@ def search(args)

if response.respond_to?(:records)
records = serialize_records(response.records)
records.each { |record| record.run_callbacks :search }
end
end

Expand All @@ -114,15 +111,6 @@ def validate_search_args!(args)
end
end

# :noapi:
def _active_remote_search(args)
warn "DEPRECATED Model#_active_remote_search is depracted and will be remoted in Active Remote 3.0."

run_callbacks :search do
rpc.execute(:search, args)
end
end

# Reload this record from the remote service.
#
def reload
Expand Down