Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capture options on set-enabled APIs #251

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jun 7, 2022

Will tackle "mute instead of unpublish" for screenshare in a separate PR.
Making the functionality available seems like higher priority for now than the internal handling of it.

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: 36c6e82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao June 7, 2022 09:37
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API looks really clean. well done!

@davidzhao
Copy link
Member

Should this be a minor or patch version? given the new options.

@lukasIO
Copy link
Contributor Author

lukasIO commented Jun 8, 2022

yeah, we could introduce it in the next minor release!
Once we merge it to main, that would mean the next release would be v1.1, probably makes sense to release v1.0.2 before with the recent bugfixes?

@lukasIO lukasIO changed the title Add support for respective capture options on set-enabled APIs Add support for capture options on set-enabled APIs Jun 8, 2022
@davidzhao
Copy link
Member

good point, yeah, saving this one for 1.1

@theomonnom theomonnom merged commit 48a5e3b into main Jun 14, 2022
@theomonnom theomonnom deleted the lukas/screenshare-audio-apis branch June 14, 2022 07:14
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants