-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capture options on set-enabled APIs #251
Conversation
🦋 Changeset detectedLatest commit: 36c6e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API looks really clean. well done!
Should this be a minor or patch version? given the new options. |
yeah, we could introduce it in the next minor release! |
good point, yeah, saving this one for 1.1 |
Will tackle "mute instead of unpublish" for screenshare in a separate PR.
Making the functionality available seems like higher priority for now than the internal handling of it.